Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed chakra provider missing/single child issue #2006

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

BLuEScioN
Copy link
Collaborator

@BLuEScioN BLuEScioN commented Feb 13, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Fixes bug that causes crash due to the content not being wrapped by a chakra provider (production error), or a React element having more than a single child component (local error)

The issue was with the wallet icon which was not rendering correctly. Refactoring it into a phosphor icon and using the usual icon structure fixed this issue

Slack context: https://hiropbc.slack.com/archives/C03TU42NL05/p1739474432135939

Issue ticket number and link

Checklist:

  • I have performed a self-review of my code.
  • I have tested the change on desktop and mobile.
  • I have added thorough tests where applicable.
  • I've added analytics and error logging where applicable.

Screenshots (if appropriate):

@BLuEScioN BLuEScioN requested a review from He1DAr February 13, 2025 20:18
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 8:21pm
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 8:21pm

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/features/search/items/address-result-item.tsx 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@BLuEScioN BLuEScioN merged commit eefd2a7 into main Feb 13, 2025
14 of 17 checks passed
@BLuEScioN BLuEScioN deleted the fix/chakra-provider-missing-in-search branch February 13, 2025 20:26
@blockstack-devops
Copy link

🎉 This PR is included in version 1.249.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants